Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for rack 2.0.8 #28

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Fix for rack 2.0.8 #28

merged 3 commits into from
Jan 13, 2020

Conversation

le0pard
Copy link
Contributor

@le0pard le0pard commented Dec 19, 2019

No description provided.

Copy link

@madmatvey madmatvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need integration tests.

@le0pard
Copy link
Contributor Author

le0pard commented Dec 23, 2019

@madmatvey I cannot write tests, because this changes depend from redis-rack and I cannot point to branch in gemfile spec (need point to new redis-rack version with fixes)

@tubbo
Copy link
Contributor

tubbo commented Jan 13, 2020

@le0pard these tests passed when I ran bundle update locally. now that your PR is merged to redis-rack, you should be able to test against the new API by adding this to Gemfile:

gem 'redis-rack', github: 'redis-store/redis-rack'

@le0pard
Copy link
Contributor Author

le0pard commented Jan 13, 2020

@tubbo Big thanks. I added redis-rack from github for testing purpose, but you need to remove it after release new redis-rack version :)

@tubbo tubbo merged commit c82d492 into redis-store:master Jan 13, 2020
@le0pard le0pard deleted the rack_208 branch January 13, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants