Updates to support Fedora #134
Conversation
spoore1
force-pushed
the
fedora_updates
branch
2 times, most recently
from
9530c5a to
1fafde8
Compare
|
Technically looks good to me. Again, I would wait for George to make sure this works, but I do not expect any hiccups. One note is the linter warning that might make sense to address:
|
spoore1
force-pushed
the
fedora_updates
branch
2 times, most recently
from
28ec510 to
78b6f4e
Compare
@Jakuje thanks for the review. I think I fixed the linter issue and I added the check_home_screen function. Was that in place when you approved? or do you want to take another look at that? |
spoore1
force-pushed
the
fedora_updates
branch
from
78b6f4e to
9a878b2
Compare
|
I have tested the changes (+ the nitpicks) on Fedora 39 and Fedora 38 and the tests are passing. I haven't tested all the tests but the most important ones are ok. If some tweaks are needed we can do them later if necessary. |
controller.py: - dnf groups 'Server with GUI' and 'Smart Card Support' do not exist in Fedora. Running dnf installs for minimal packages in these cases. - python3-uinput is needed in newer version of Fedora instead of the older python-uinput used from Pypi. Older version uses a deprecated sysconfig variable (SO) which is fixed in python3-uinput. - rsyslog is needed by the tests for checking /var/log/secure. setup.py: - dropping python-uinput to let the controller install the appropriate version. models/gui.py: - Add check_home_screen helper function to be used in SC-tests.
spoore1
force-pushed
the
fedora_updates
branch
from
9a878b2 to
81c0df4
Compare
|
Run the tests again and they pass on f39 and f38 with the changes (except for the lock_on_removal one which is expected after the mail discussion). I think we can merge @spoore1 if you are finished. |
|
Hello @spoore1, have you done with this PR? I remember you said that you wanted to add some more code but I do not see any movement so perhaps I was mistaken. |
|
Hi @GeorgePantelakis sorry about the delay. I was investigating using kb_send(125) to send the Super/Windows key press for a fix to some of the lock-on-removal failures after unlock. I see more issues though as I dig into the lock-on-removal tests so I think that we can call this PR done for now. I may have other changes for my SC-tests one but I think this one is done. |
|
Hello @spoore1, Since this PR is considered done and intertwined with the SC-tests PR, I will go ahead and merge both of them. There is no new code added and the old code has been tested already. Feel free to create a new PR for both projects as needed. Thank you very much for your contribution! |
controller.py:
setup.py: