Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Multiple pipeline templates in code completion #611

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

sudhirverma
Copy link
Contributor

Fix: #355

@sudhirverma sudhirverma requested a review from evidolob July 26, 2021 17:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #611 (dc94184) into master (d8dc1fa) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head dc94184 differs from pull request most recent head ddcc69f. Consider uploading reports for the commit ddcc69f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
- Coverage   68.20%   68.17%   -0.04%     
==========================================
  Files         103      103              
  Lines        6316     6316              
  Branches     1146     1146              
==========================================
- Hits         4308     4306       -2     
- Misses       2008     2010       +2     
Impacted Files Coverage Δ
src/kubectl.ts 41.37% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8dc1fa...ddcc69f. Read the comment docs.

@evidolob
Copy link
Collaborator

@sudhirverma You modify existing template, but #355 require providing additional templates:

  • Build app (maven) - build image (buildah) - deploy (kubectl) pipeline
  • Conditional pipeline
  • Pipelines with finally tasks

The purpose of the issue was having more template, not one complex.

@@ -28,10 +28,35 @@ const snippets: { [key: string]: Snippet } = {
body: load('taskrun.yaml'),
},
'Pipeline': {
prefix: 'Pipeline',
prefix: 'Pipeline-test',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you rename this?

@@ -0,0 +1,9 @@
apiVersion: tekton.dev/v1beta1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you combine pipeline-with-buildah-task.yaml, pipeline-with-kubectl-task.yaml and pipeline-with-maven-task.yaml in to one template

@sudhirverma sudhirverma requested a review from evidolob July 28, 2021 11:39
@@ -0,0 +1,15 @@
apiVersion: tekton.dev/v1beta1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pipeline template should be extended, you just referring to commands but template doesn't provide configuration for them.

@sudhirverma sudhirverma requested a review from evidolob July 29, 2021 12:38
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudhirverma sudhirverma merged commit a4e2461 into redhat-developer:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple pipeline templates in code completion
3 participants