Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands to get PipelineRun and TaskRun logs in to k8s tree #247

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

evidolob
Copy link
Collaborator

This PR adds two commands Show Log and Follow Logs in kubernetos tree for PipelineRun and TaskRun items:

Note: Getting logs implemented with tkn cli (exactly the dame as for Tekton tree), it is possible to fetch logs using pure kubernetos API but it requires a big effort, basically we need to re implement part of tkn CLI: https://github.com/tektoncd/cli/blob/6dad772d2bd697c0f66ec404a4db73b449b2cfa3/pkg/log/task_reader.go#L101
https://github.com/tektoncd/cli/blob/6dad772d2bd697c0f66ec404a4db73b449b2cfa3/pkg/log/pipeline_reader.go#L85

Screenshot 2020-04-14 at 15 30 42

Screenshot 2020-04-14 at 15 30 24

Fix: #2

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Apr 14, 2020
@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #247 into master will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   71.15%   71.33%   +0.18%     
==========================================
  Files          37       38       +1     
  Lines        2368     2383      +15     
  Branches      397      401       +4     
==========================================
+ Hits         1685     1700      +15     
  Misses        683      683              
Impacted Files Coverage Δ
src/extension.ts 89.71% <100.00%> (+0.09%) ⬆️
src/kubernetes.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fbbe0...db3e934. Read the comment docs.

@evidolob evidolob merged commit 878c849 into master Apr 15, 2020
@evidolob evidolob deleted the logs-from-kubernetos-tree branch April 15, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display build logs from cluster view
3 participants