-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new icon in tree view resource #191
Conversation
sudhirverma
commented
Mar 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 73.41% 73.44% +0.02%
==========================================
Files 33 33
Lines 1892 1894 +2
Branches 292 293 +1
==========================================
+ Hits 1389 1391 +2
Misses 503 503
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch to test preview with new icons https://gist.github.com/evidolob/40a90c1bdd77dba72743d362b7ac0ac3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected.
Please delete unused resources(png/svg), to make repository clear
@sudhirverma Please add icon description in README.md https://github.com/redhat-developer/vscode-tekton#icons-representation |