-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use condition name for 'Condition' node in pipeline run child nodes #277
Comments
@siamaksade We are showing condition run as taskrun nodes, but |
I just want to add that we display conditions in two different ways based on the position in the tree. The one Yevhen described, as children of a taskrun node under a pipelinerun node and as normal taskrun nodes under the taskruns root node. We took this decision because we thought it would be clearer from a user perspective to understand which condition failed and what was the task it was related to when starting a pipeline, but we show them as normal taskrun nodes under taskrun root node because they are treated as taskruns in tekton. BTW we are open to suggestion as well. If you find a better solution we are always ready to steal it from vscode ;) And also, if you need any other info, feel free to ask :) |
I was going to ask for this, @evidolob looks like you have beaten me to it. I think the way intellij-tekton shows conditions on a pipelinerun is more helpful, +1 to converge on that. |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
* #277 show condition run as child for taskrun Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix all issues related to start and refreash tree Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * remove unused variables Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * add more descriptive message in case taskrun load error Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Use new state icons for some tree items Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Now if task has condition we add item in the tree with task name not with condition name:

We need to use condition name for that tree item.
The text was updated successfully, but these errors were encountered: