Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding login/logout test #3977

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Adding login/logout test #3977

merged 2 commits into from
Mar 12, 2024

Conversation

lgrossma
Copy link
Contributor

@lgrossma lgrossma commented Mar 11, 2024

See: #3685

Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (da60441) to head (f17c715).
Report is 102 commits behind head on main.

❗ Current head f17c715 differs from pull request most recent head 8857c62. Consider uploading reports for the commit 8857c62 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3977       +/-   ##
===========================================
+ Coverage   32.37%   45.18%   +12.81%     
===========================================
  Files          85       85               
  Lines        6505     6670      +165     
  Branches     1349     1389       +40     
===========================================
+ Hits         2106     3014      +908     
+ Misses       4399     3656      -743     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vrubezhny
vrubezhny previously approved these changes Mar 12, 2024
Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't package the kubectl into the built extension

kubectl Outdated Show resolved Hide resolved
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Lukas!

@datho7561 datho7561 merged commit 2553f5e into redhat-developer:main Mar 12, 2024
4 checks passed
@lgrossma
Copy link
Contributor Author

I ran the tests again with the changes and they still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants