-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding login/logout test #3977
Adding login/logout test #3977
Conversation
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
===========================================
+ Coverage 32.37% 45.18% +12.81%
===========================================
Files 85 85
Lines 6505 6670 +165
Branches 1349 1389 +40
===========================================
+ Hits 2106 3014 +908
+ Misses 4399 3656 -743 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't package the kubectl into the built extension
Signed-off-by: Lukas Grossmann <lgrossma@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, Lukas!
I ran the tests again with the changes and they still pass. |
See: #3685