Add capability to select projects to be imported #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snjeza
previously approved these changes
Oct 24, 2023
jdneo
changed the title
jdneo
force-pushed
the
cs/project-picker
branch
2 times, most recently
from
ec9c125
to
91de44f
Compare
|
Some major changes are made according to the feedback in last meeting:
|
jdneo
changed the title
jdneo
force-pushed
the
cs/project-picker
branch
from
11dd112
to
6b85b7f
Compare
|
@jdneo You should respect |
Yes it's taken into account: vscode-java/src/buildFilesSelector.ts Line 14 in 6b85b7f |
Could you try the example at #2537 (comment)? It includes the |
Done. |
snjeza
approved these changes
Nov 13, 2023
jdneo
force-pushed
the
cs/project-picker
branch
from
9bd874c
to
af5953a
Compare
- A new setting `java.import.configurationFileCollectionMode` is added to configure whether manually build file selection is required before import. - A new contribution point `javaBuildTypes` is introduced, and will be used when the build files need to be manually selected. Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: Sheng Chen <sheche@microsoft.com>
Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
force-pushed
the
cs/project-picker
branch
from
af5953a
to
a14fd7e
Compare
Signed-off-by: Sheng Chen <sheche@microsoft.com>
testforstephen
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with eclipse-jdtls/eclipse.jdt.ls#2913