This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
Apply CSV best practices #1020
Merged
Apply CSV best practices #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pedjak
commented
Sep 13, 2021
•
pedjak
commented
- added annotation that indicates that the operator can be deployed in disconnected environments
- specified minimal supported kube version
- added containerImage annotation
- maturity set to 'candidate'
- explicit service account dropped from bundle
- common label renamed to service-binding-controller-manager
pmacik
reviewed
Sep 13, 2021
config/manifests/bases/service-binding-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
* added annotation that indicates that the operator can be deployed in disconnected environments * specified minimal supported kube version * added containerImage annotation * maturity set to 'candidate' * explicit service account dropped from bundle * common label renamed to service-binding-controller-manager Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
pedjak
force-pushed
the
csv-best-practices
branch
from
da91819
to
1becc59
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1020 +/- ##
=======================================
Coverage 56.87% 56.87%
=======================================
Files 28 28
Lines 1556 1556
=======================================
Hits 885 885
Misses 555 555
Partials 116 116 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.