This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
panic on invalid sourceValue
#967
Comments
|
Associated with PR #993 |
|
We've seen this happen in the Developer Sandbox with SBO 0.9.1: |
sadlerap
pushed a commit
to sadlerap/service-binding-operator
that referenced
this issue
Sep 8, 2021
) A service can have a sliceOfMaps-based element annotation. For example: service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf When sourceValue is incorrect, the operator would panic, since it didn't verify that the sourceValue was incorrect. Now, it sets an error condition in the reconciler (which propogates to the binding status). Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
pushed a commit
to sadlerap/service-binding-operator
that referenced
this issue
Sep 9, 2021
) A service can have a sliceOfMaps-based element annotation. For example: service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf When sourceValue is incorrect, the operator would panic, since it didn't verify that the sourceValue was incorrect. Now, it sets an error condition in the reconciler (which propogates to the binding status). Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
pushed a commit
to sadlerap/service-binding-operator
that referenced
this issue
Sep 9, 2021
) A service can have a sliceOfMaps-based element annotation. For example: service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf When sourceValue is incorrect, the operator would panic, since it didn't verify that the sourceValue was incorrect. Now, it sets an error condition in the reconciler (which propogates to the binding status). Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
pushed a commit
to sadlerap/service-binding-operator
that referenced
this issue
Sep 10, 2021
) A service can have a sliceOfMaps-based element annotation. For example: service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf When sourceValue is incorrect, the operator would panic, since it didn't verify that the sourceValue was incorrect. Now, it sets an error condition in the reconciler (which propogates to the binding status). Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
pushed a commit
to sadlerap/service-binding-operator
that referenced
this issue
Sep 10, 2021
) A service can have a sliceOfMaps-based element annotation. For example: service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf When sourceValue is incorrect, the operator would panic, since it didn't verify that the sourceValue was incorrect. Now, it sets an error condition in the reconciler (which propogates to the binding status). Signed-off-by: Andy Sadler <ansadler@redhat.com>
openshift-merge-robot
pushed a commit
that referenced
this issue
Sep 10, 2021
A service can have a sliceOfMaps-based element annotation. For example:
service.binding/java-maven_port: path={.spec.ports},elementType=sliceOfMaps,sourceKey=name,sourceValue=asdf
When sourceValue is incorrect, the operator would panic, since it didn't
verify that the sourceValue was incorrect. Now, it sets an error
condition in the reconciler (which propogates to the binding status).
Signed-off-by: Andy Sadler <ansadler@redhat.com>
Co-authored-by: Igor Sutton <isuttonl@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the environment (Minikube, Openshift)?
CodeReady Containers version: 1.26.0+31f06c09
OpenShift version: 4.7.8 (embedded in executable)
What is the SBO version used?
v0.7.1
What are the steps to reproduce this issue?
Servicewith invalidsourceValueServiceBindingbetween deployment andServicethat has above annotation.What is the expected behaviour?
stats.conditionshould have an error telling me that I have specified invalidsourceValueWhat is the actual behaviour?
operator throws panic
Service Binding Operator Logs
Additional Information (Screenshots, etc)
The text was updated successfully, but these errors were encountered: