collect: Rename specs to clarify intent of testing

Signed-off-by: Andy Sadler <ansadler@redhat.com>
redhat-developer · Sep 7, 2021 · 90cf30f · 90cf30f
1 parent 5b66fa5
commit 90cf30f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pkg/reconcile/pipeline/handler/collect/impl.go b/pkg/reconcile/pipeline/handler/collect/impl.go
@@ -26,7 +26,8 @@ const (
 	ErrorReadingDescriptorReason = "ErrorReadingDescriptor"
 	ErrorReadingBindingReason    = "ErrorReadingBinding"
 	ErrorReadingSecret           = "ErrorReadingSecret"
-	ValueNotFound                = "ValueNotFound"
+
+	ValueNotFound = "ValueNotFound"
 )
 
 func PreFlight(ctx pipeline.Context) {

diff --git a/pkg/reconcile/pipeline/handler/collect/impl_test.go b/pkg/reconcile/pipeline/handler/collect/impl_test.go
@@ -1030,8 +1030,7 @@ var _ = Describe("Integration Collect definitions + items", func() {
 
 })
 
-// TODO: spec title should be rephrased: should we have one spec for regression tests?
-var _ = Describe("Issue 943", func() {
+var _ = Describe("Handle invalid sliceOfMap annotations", func() {
 	var (
 		mockCtrl *gomock.Controller
 	)
@@ -1051,7 +1050,7 @@ var _ = Describe("Issue 943", func() {
 		configMaps     map[string]*unstructured.Unstructured
 	}
 
-	It("retrieve binding data",
+	It("should set an error condition",
 		func() {
 			tc := testCase{
 				serviceContent: map[string]interface{}{