Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

No license for rh-che project #192

Closed
sunix opened this issue Jul 13, 2017 · 3 comments
Closed

No license for rh-che project #192

sunix opened this issue Jul 13, 2017 · 3 comments
Assignees
@JPinkney
Labels
kind/task level/beginner severity/P2 status/open-for-dev

Comments

@sunix
Copy link
Contributor

sunix commented Jul 13, 2017

There is no LICENSE file nor license header in source code files (java, xml ...)
Which license are we suppose to use ?
davidfestal added a commit to davidfestal/rh-che that referenced this issue Jul 13, 2017
@davidfestal
Add the license header and fix the Javadoc.
ee3a7a6 
For the moment the added license header is consistent with the other
headers of the package.

However, a global rework of license headers in `rh-che` might be
necessary as stated in issue
redhat-developer#192

Signed-off-by: David Festal <dfestal@redhat.com>
@davidfestal davidfestal mentioned this issue Jul 13, 2017
Merged
davidfestal added a commit that referenced this issue Jul 13, 2017
@davidfestal
Add the license header and fix the Javadoc. (#193)
8bb83a6 
For the moment the added license header is consistent with the other
headers of the package.

However, a global rework of license headers in `rh-che` might be
necessary as stated in issue
#192

Signed-off-by: David Festal <dfestal@redhat.com>
@l0rd
Copy link
Contributor

l0rd commented Jul 13, 2017

As for the license type I would say EPL. @gorkem ?

For the copyright headers I think most of the java source files already have one and we should verify it and enforce a check at build time (for .xml, .sh etc...too of course).

@gorkem
Copy link
Contributor

gorkem commented Jul 13, 2017

Yes, EPL is the natural choice.

@l0rd l0rd mentioned this issue Sep 8, 2017
Closed
@JPinkney JPinkney self-assigned this Sep 12, 2017
@JPinkney JPinkney mentioned this issue Sep 12, 2017
Merged
@JPinkney
Copy link
Contributor

Fixed as part of #332

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JPinkney JPinkney

Labels
kind/task level/beginner severity/P2 status/open-for-dev
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gorkem @l0rd @sunix @ibuziuk @JPinkney