Removing support for github based registries #5708

mohammedzee1000 · 2022-05-02T07:58:41Z

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

What type of PR is this:

/kind task

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5579

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:
You should no longer be able to add, update, list GitHub based registries
odo preference registry add should not allow github registry urls
list should not show github registries
update should not allow github registries

./odo preference registry list  
NAME                       URL                                           SECURE
CheRegistry                https://che-devfile-registry.openshift.io     No
DefaultDevfileRegistry     https://registry.devfile.io                   No
./odo preference registry add test https://github.com/elsony/devfile-registry
 ✗  github based registries are no longer supported, use https://github.com/devfile/registry-support instead
 ./odo preference registry update CheRegistry https://github.com/elsony/devfile-registry
 ✗  github based registries are no longer supported, use https://github.com/devfile/registry-support instead

netlify · 2022-05-02T07:58:59Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`a8f7f66`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6274ef4a5026690008724a85

odo-robot · 2022-05-02T08:05:51Z

Unit Tests on commit 00773fb finished successfully.
View logs: TXT HTML

odo-robot · 2022-05-02T08:07:25Z

Windows Tests (OCP) on commit 00773fb finished successfully.
View logs: TXT HTML

odo-robot · 2022-05-02T08:08:00Z

Kubernetes Tests on commit 00773fb finished with errors.
View logs: TXT HTML

odo-robot · 2022-05-02T08:08:03Z

OpenShift Tests on commit 00773fb finished successfully.
View logs: TXT HTML

odo-robot · 2022-05-02T08:14:15Z

Validate Tests on commit 00773fb finished successfully.
View logs: TXT HTML

mohammedzee1000 · 2022-05-02T12:53:13Z

/test unit
could not find golang-lint

mohammedzee1000 · 2022-05-02T12:54:39Z

/test v4.10-integration-e2e
infra issue

feloy · 2022-05-03T06:27:05Z

pkg/registry/registry.go

-}
-
-const indexPath = "/devfiles/index.json"
+// const indexPath = "/devfiles/index.json" :Not sure if this should be removed but it is not used for now


If this iss not used, let's remove it

feloy · 2022-05-03T06:28:24Z

pkg/registry/registry.go


 // getRegistryStacks retrieves the registry's index devfile stack entries
 func getRegistryStacks(preferenceClient preference.Client, registry Registry) ([]DevfileStack, error) {
-	if !strings.Contains(registry.URL, "github") {
+	if !registryUtil.IsGithubBasedRegistry(registry.URL) {


Please do the other way as usual:

if registryUtil.IsGithubBasedRegistry(registry.URL) { return nil, registryUtil.ErrGithubRegistryNotSupported } // OCI-based registry ...

feloy · 2022-05-04T06:43:01Z

tests/integration/devfile/cmd_devfile_registry_test.go

-			It("should not show deprecation warning if git registry is not used for component creation", func() {
-				out, err = helper.Cmd("odo", "init", "--name", "aname", "--devfile", "nodejs", "--devfile-registry", "DefaultDevfileRegistry").ShouldPass().OutAndErr()
-				helper.DontMatchAllInOutput(fmt.Sprintln(out, err), []string{deprecated, docLink})
+			It("should fail with error", func() {


You have two When's without any BeforeEach, you can remove both of them and have only one It("should fail adding a git based registry", ...

pkg/odo/cli/preference/registry/util/util.go

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

pkg/init/backend/flags.go

pkg/odo/cli/preference/registry/util/util.go

tests/integration/devfile/cmd_devfile_registry_test.go

Co-authored-by: Armel Soro <armel@rm3l.org>

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

sonarcloud · 2022-05-06T09:52:11Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

rm3l

LGTM - thanks.

I can see a test not passing on IBM Cloud, but that does not seem related to the changes in this PR:

• Failure [380.063 seconds]
odo dev command tests
/workspace/c1645ecf-e7f2-4095-8aff-fbec607d1fa1/tests/integration/devfile/cmd_dev_test.go:25
  when a component is bootstrapped and pushed
  /workspace/c1645ecf-e7f2-4095-8aff-fbec607d1fa1/tests/integration/devfile/cmd_dev_test.go:55
    should show validation errors if the devfile is incorrect [It]
    /workspace/c1645ecf-e7f2-4095-8aff-fbec607d1fa1/tests/integration/devfile/cmd_dev_test.go:61

    Timed out after 360.001s.
    Expected
        <string>:   __
         /  \__     Developing using the wgpujt Devfile
         \__/  \    Namespace: cmd-dev-test61nde
         /  \__/    odo version: v3.0.0-alpha1
         \__/
        
        ↪ Deploying to the cluster in developer mode
         •  Waiting for Kubernetes resources  ...
         ✗  Waiting for Kubernetes resources [32s]
        Cleaning resources, please wait
        
    to contain substring
        <string>: Press Ctrl+c to exit `odo dev` and delete resources from the cluster

    /workspace/c1645ecf-e7f2-4095-8aff-fbec607d1fa1/tests/helper/helper_run.go:39
------------------------------


Summarizing 1 Failure:

[Fail] odo dev command tests when a component is bootstrapped and pushed [It] should show validation errors if the devfile is incorrect 
/workspace/c1645ecf-e7f2-4095-8aff-fbec607d1fa1/tests/helper/helper_run.go:39

Ran 122 of 122 Specs in 426.984 seconds
FAIL! -- 121 Passed | 1 Failed | 0 Pending | 0 Skipped

feloy · 2022-05-06T18:53:07Z

/approve

openshift-ci · 2022-05-06T18:53:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feloy · 2022-05-06T18:54:33Z

/override Kubernetes Integration Tests/Kubernetes Integration Tests

openshift-ci · 2022-05-06T18:54:36Z

@feloy: Overrode contexts on behalf of feloy: Kubernetes Integration Tests/Kubernetes Integration Tests

In response to this:

/override Kubernetes Integration Tests/Kubernetes Integration Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Armels

* Removing support for github based registries Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Updating tests Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Renaming some funcs Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding https://github.com/devfile/registry-support info Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Commenting out unused const Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing potential for github registry use in odo init Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unused constant Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Reversing order Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Making error more readable Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Simpifying test Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing as per @Armels comments Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Update pkg/odo/cli/preference/registry/util/util.go Co-authored-by: Armel Soro <armel@rm3l.org> * Updating uts Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> Co-authored-by: Armel Soro <armel@rm3l.org>

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/task Issue is actionable task labels May 2, 2022

openshift-ci bot requested review from rm3l and valaparthvi May 2, 2022 07:59

mohammedzee1000 changed the title ~~WIP Removing support for github based registries~~ Removing support for github based registries May 2, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 2, 2022

mohammedzee1000 changed the title ~~Removing support for github based registries~~ WIP Removing support for github based registries May 2, 2022

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 2, 2022

mohammedzee1000 changed the title ~~WIP Removing support for github based registries~~ Removing support for github based registries May 2, 2022

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 2, 2022

feloy suggested changes May 3, 2022

View reviewed changes

openshift-ci bot assigned feloy May 3, 2022

feloy suggested changes May 4, 2022

View reviewed changes

feloy approved these changes May 4, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 4, 2022

rm3l requested changes May 5, 2022

View reviewed changes

pkg/odo/cli/preference/registry/util/util.go Outdated Show resolved Hide resolved

openshift-ci bot assigned rm3l May 5, 2022

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 5, 2022

mohammedzee1000 added 4 commits May 5, 2022 17:09

Removing support for github based registries

bf7501b

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Updating tests

615e707

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Renaming some funcs

4058235

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Adding https://github.com/devfile/registry-support info

c4d8eb7

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

mohammedzee1000 added 7 commits May 5, 2022 17:09

Commenting out unused const

9648945

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Removing potential for github registry use in odo init

66337f8

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Removing unused constant

770b89e

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Reversing order

cdf32fc

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Making error more readable

151c29b

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Simpifying test

05a63ad

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

Fixing as per @Armels comments

28d9787

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

mohammedzee1000 force-pushed the git_df_registry branch from 3d99c70 to 28d9787 Compare May 5, 2022 11:40

rm3l requested changes May 5, 2022

View reviewed changes

pkg/init/backend/flags.go Show resolved Hide resolved

pkg/odo/cli/preference/registry/util/util.go Outdated Show resolved Hide resolved

tests/integration/devfile/cmd_devfile_registry_test.go Show resolved Hide resolved

mohammedzee1000 and others added 2 commits May 6, 2022 15:12

Update pkg/odo/cli/preference/registry/util/util.go

0fe0009

Co-authored-by: Armel Soro <armel@rm3l.org>

Updating uts

a8f7f66

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>

mohammedzee1000 requested a review from rm3l May 6, 2022 12:32

rm3l approved these changes May 6, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 6, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 6, 2022

openshift-merge-robot merged commit ee17f5f into redhat-developer:main May 6, 2022

mohammedzee1000 deleted the git_df_registry branch May 9, 2022 07:06

rm3l added v3 and removed v3 labels Oct 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing support for github based registries #5708

Removing support for github based registries #5708

mohammedzee1000 commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

mohammedzee1000 commented May 2, 2022 •

edited

Loading

mohammedzee1000 commented May 2, 2022

feloy May 3, 2022

mohammedzee1000 May 4, 2022

feloy May 3, 2022

feloy May 4, 2022

sonarcloud bot commented May 6, 2022

rm3l left a comment

feloy commented May 6, 2022

openshift-ci bot commented May 6, 2022

feloy commented May 6, 2022

openshift-ci bot commented May 6, 2022

Removing support for github based registries #5708

Removing support for github based registries #5708

Conversation

mohammedzee1000 commented May 2, 2022 • edited Loading

netlify bot commented May 2, 2022 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

odo-robot bot commented May 2, 2022 • edited Loading

odo-robot bot commented May 2, 2022 • edited Loading

odo-robot bot commented May 2, 2022 • edited Loading

odo-robot bot commented May 2, 2022 • edited Loading

odo-robot bot commented May 2, 2022 • edited Loading

mohammedzee1000 commented May 2, 2022 • edited Loading

mohammedzee1000 commented May 2, 2022

feloy May 3, 2022

Choose a reason for hiding this comment

mohammedzee1000 May 4, 2022

Choose a reason for hiding this comment

feloy May 3, 2022

Choose a reason for hiding this comment

feloy May 4, 2022

Choose a reason for hiding this comment

sonarcloud bot commented May 6, 2022

rm3l left a comment

Choose a reason for hiding this comment

feloy commented May 6, 2022

openshift-ci bot commented May 6, 2022

feloy commented May 6, 2022

openshift-ci bot commented May 6, 2022

mohammedzee1000 commented May 2, 2022 •

edited

Loading

netlify bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

odo-robot bot commented May 2, 2022 •

edited

Loading

mohammedzee1000 commented May 2, 2022 •

edited

Loading