Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies to address dependabot alerts #4912

Merged
merged 5 commits into from
Jul 15, 2021
Merged

Updating dependencies to address dependabot alerts #4912

merged 5 commits into from
Jul 15, 2021

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Jul 13, 2021

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:
Updates the nodejs dependencies in website/* directory. Updated based on the pointers provided by GitHub Dependabot Alerts

Which issue(s) this PR fixes:

Fixes N/A

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

  • Update changelog

  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jul 14, 2021

✔️ Deploy Preview for odo-docusaurus-preview ready!

🔨 Explore the source changes: ad15b4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/60ee9b67ad31ea0008fed65d

😎 Browse the preview: https://deploy-preview-4912--odo-docusaurus-preview.netlify.app

README.adoc Outdated
@@ -6,6 +6,7 @@

https://github.com/openshift/odo/releases/latest[image:https://img.shields.io/github/v/release/openshift/odo?style=for-the-badge[GitHub release]]
image:https://img.shields.io/github/license/openshift/odo?style=for-the-badge[License]
image:https://api.netlify.com/api/v1/badges/e07867b0-56a4-4905-92a9-a152ceab5f0d/deploy-status[![Netlify Status]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add link that will point to our netlify side? similarly like it is done for release badge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean. 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you mean it should be a link to a page on netlify instead of just an image. Weirdly, it was working earlier. Let me check what went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@feloy
Copy link
Contributor

feloy commented Jul 15, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 15, 2021
@kadel
Copy link
Member

kadel commented Jul 15, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 9237d8d into redhat-developer:main Jul 15, 2021
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Jul 27, 2021
…4912)

* Updating dependencies to address dependabot alerts

* Adds Netlify Status badge to repo's README

* Remove unused page

* Update README for website directory

* Add link to Netlify's badge
@dharmit dharmit deleted the dependabot-alerts branch October 21, 2021 07:17
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants