-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --devfile flag support #3118
Merged
openshift-merge-robot
merged 35 commits into
redhat-developer:master
from
GeekArthur:issue-2862-devfileFlag
Jun 10, 2020
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
7b39137
feat: add --devfile flag support
GeekArthur 4f12152
fix: fix gosec G307 issue
GeekArthur 301c3e6
fix: update error handling
GeekArthur ab94c3b
style: Update help and error messages
GeekArthur 5b87a60
fix: Improve performance of error handling
GeekArthur ed1fbf3
style: Improve error message
GeekArthur e2118c3
fix: Fix remove file error on Windows
GeekArthur ab43b6d
fix: Use existing structure to handle temp file
GeekArthur dba1b4b
refactor: rebase onto master
GeekArthur b1a599d
refactor: improve code readability and structure
GeekArthur 613dfae
docs: update variable comments
GeekArthur 1475068
feat: --devfile value supports http(s)
GeekArthur 520de2c
feat: remove --devfile for all other commands
GeekArthur 4841a29
refactor: rebase onto master
GeekArthur e21b2c3
feat: add new design for existing devfile support
GeekArthur 9a8dbcf
test: update TestCopyFile test cases
GeekArthur 30e9db7
test: refactor file copy util function for test
GeekArthur 4d42536
test: fix TestCopyFile test cases
GeekArthur 9eb7f70
test: add integration tests for existing devfile
GeekArthur eb74657
refactor: rebase onto master
GeekArthur 4583b7f
fix: gosec issue
GeekArthur 20206d7
test: fix docker url integration tests
GeekArthur 701a4ab
fix: context support
GeekArthur 91b7537
test: fix docker url integration tests
GeekArthur c0dc7d7
fix: handle edge cases and add related tests
GeekArthur 4bc977f
refactor: separate spinner for existing devfile
GeekArthur 8d4a336
refactor: rebase onto master
GeekArthur 6cff5e7
test: fix docker watch tests
GeekArthur 20235df
refactor: rebase onto master
GeekArthur a770c83
Merge branch 'master' of github.com:openshift/odo into issue-2862-dev…
GeekArthur c2ae87c
test: fix url tests
GeekArthur 5f9240a
Merge branch 'master' of github.com:openshift/odo into issue-2862-dev…
GeekArthur 69ad017
Merge branch 'master' of github.com:openshift/odo into issue-2862-dev…
GeekArthur 7ac65f2
Merge branch 'master' of github.com:openshift/odo into issue-2862-dev…
GeekArthur 30a95c4
Merge branch 'master' of github.com:openshift/odo into issue-2862-dev…
GeekArthur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍