-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates odo describe
output
#2231
Updates odo describe
output
#2231
Conversation
Updates the `odo describe` output to be a bit more intuitive / better looking.
Adds the "secrets" or environment variables that have been passed into the component by using the `odo link` feature when connecting to a database. Builds upon PR: redhat-developer#2231 Closes: redhat-developer#2232 See the below example of how it now looks like: ```sh Component Name: nodejs-nodejs-ex-cstb Type: nodejs Source: file://./ Environment Variables: · foo=bar · bar=foo · DEBUG_PORT=5858 Storage: · mystorage of size 1Gi mounted to /opt/app-root/src/storage/ URLs: · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080 Linked Components: · nodejs2 - Port(s): 8080 Linked Services: · mongodb-persistent Environment Variables: · uri · username · admin_password · database_name · password · dh-mysql-apb Environment Variables: · DB_HOST · DB_NAME · DB_PASSWORD · DB_PORT · DB_TYPE · DB_USER ```
Looks the same on windows? |
as a follow up show we change the output of |
@girishramnani Yes, we should change it in Yup! Works on Windows. |
Cool, |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
An issue to track the follow up task would be great @cdrage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adds the "secrets" or environment variables that have been passed into the component by using the `odo link` feature when connecting to a database. Builds upon PR: redhat-developer#2231 Closes: redhat-developer#2232 See the below example of how it now looks like: ```sh Component Name: nodejs-nodejs-ex-cstb Type: nodejs Source: file://./ Environment Variables: · foo=bar · bar=foo · DEBUG_PORT=5858 Storage: · mystorage of size 1Gi mounted to /opt/app-root/src/storage/ URLs: · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080 Linked Components: · nodejs2 - Port(s): 8080 Linked Services: · mongodb-persistent Environment Variables: · uri · username · admin_password · database_name · password · dh-mysql-apb Environment Variables: · DB_HOST · DB_NAME · DB_PASSWORD · DB_PORT · DB_TYPE · DB_USER ```
Adds the "secrets" or environment variables that have been passed into the component by using the `odo link` feature when connecting to a database. Builds upon PR: redhat-developer#2231 Closes: redhat-developer#2232 See the below example of how it now looks like: ```sh Component Name: nodejs-nodejs-ex-cstb Type: nodejs Source: file://./ Environment Variables: · foo=bar · bar=foo · DEBUG_PORT=5858 Storage: · mystorage of size 1Gi mounted to /opt/app-root/src/storage/ URLs: · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080 Linked Components: · nodejs2 - Port(s): 8080 Linked Services: · mongodb-persistent Environment Variables: · uri · username · admin_password · database_name · password · dh-mysql-apb Environment Variables: · DB_HOST · DB_NAME · DB_PASSWORD · DB_PORT · DB_TYPE · DB_USER ```
Adds the "secrets" or environment variables that have been passed into the component by using the `odo link` feature when connecting to a database. Builds upon PR: #2231 Closes: #2232 See the below example of how it now looks like: ```sh Component Name: nodejs-nodejs-ex-cstb Type: nodejs Source: file://./ Environment Variables: · foo=bar · bar=foo · DEBUG_PORT=5858 Storage: · mystorage of size 1Gi mounted to /opt/app-root/src/storage/ URLs: · http://foobar-app-myproject.192.168.42.79.nip.io exposed via 8080 Linked Components: · nodejs2 - Port(s): 8080 Linked Services: · mongodb-persistent Environment Variables: · uri · username · admin_password · database_name · password · dh-mysql-apb Environment Variables: · DB_HOST · DB_NAME · DB_PASSWORD · DB_PORT · DB_TYPE · DB_USER ```
Updates the
odo describe
output to be a bit more intuitive / betterlooking.