Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits to Deploying an application using odo Section of README #2226

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Edits to Deploying an application using odo Section of README #2226

merged 1 commit into from
Oct 2, 2019

Conversation

danielhelfand
Copy link
Contributor

What is the purpose of this change? What does it change?

Correcting typos in README on using crc/minishift

Was the change discussed in an issue?

N/A

@openshift-ci-robot
Copy link
Collaborator

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. size/XS labels Oct 2, 2019
danielhelfand
danielhelfand commented Oct 2, 2019
View reviewed changes
README.adoc

. Start a local OpenShift development cluster by using `minishift` or `crc`.
+
[source,bash]
----
$ minishift start
$ # or
# or
Copy link
Contributor Author

@danielhelfand danielhelfand Oct 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed $ since this is a comment, not a command to execute.

cdrage
cdrage approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake!

Thanks!

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 2, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 2, 2019
@danielhelfand
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@danielhelfand: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mohammedzee1000
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Oct 2, 2019
@mohammedzee1000
Copy link
Contributor

@cdrage make sure you do ok-to-test on prs that need them or prow will not run

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@cdrage
Copy link
Member

cdrage commented Oct 2, 2019

/retest

1 similar comment
@danielhelfand
Copy link
Contributor Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@danielhelfand
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 84200d1 into redhat-developer:master Oct 2, 2019
@danielhelfand danielhelfand mentioned this pull request Oct 3, 2019
Merged
@amitkrout amitkrout mentioned this pull request Oct 15, 2019
Merged
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danielhelfand @openshift-ci-robot @mohammedzee1000 @openshift-bot @cdrage @rm3l @openshift-merge-robot