-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes double deployment for git components on second push and later #2167
Fixes double deployment for git components on second push and later #2167
Conversation
9f4df55
to
8b90a3f
Compare
@amitkrout Let's make sure we run this 10+ times on 4.2 cluster before moving forward |
8b90a3f
to
a2d2e07
Compare
8043f0c
to
f862816
Compare
f862816
to
a71ccd9
Compare
/retest |
a71ccd9
to
1f69b69
Compare
/retest |
1f69b69
to
bff5cfa
Compare
/retest |
bff5cfa
to
4f71dfe
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Will check it on my aws OpenShift 4.2 cluster atleast for 5 consecutive run. |
I have executed 5 times on 4.2 OSD real cluster and none of the time i hit the issue of #1981 |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
fixes #1981
How to test:
test-cmd-url
on a 4.2 cluster close to 10 times and check if the error described in the issue occurs or not and also if the second push only triggers a single deployment revision.