Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes double deployment for git components on second push and later #2167

Merged

Conversation

mik-dass
Copy link
Contributor

fixes #1981

How to test:

  1. Trigger test-cmd-url on a 4.2 cluster close to 10 times and check if the error described in the issue occurs or not and also if the second push only triggers a single deployment revision.

@mik-dass
Copy link
Contributor Author

mik-dass commented Sep 24, 2019

@amitkrout Let's make sure we run this 10+ times on 4.2 cluster before moving forward

@mik-dass mik-dass changed the title Fixes double deployment for git components on second push and later [WIP] Fixes double deployment for git components on second push and later Sep 24, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 24, 2019
@mik-dass mik-dass force-pushed the fix_git_double_push branch 2 times, most recently from 8043f0c to f862816 Compare September 25, 2019 12:38
@mik-dass mik-dass changed the title [WIP] Fixes double deployment for git components on second push and later Fixes double deployment for git components on second push and later Sep 25, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Sep 25, 2019
@mik-dass
Copy link
Contributor Author

Unexpected error:
        <*os.PathError | 0xc00008ae40>: {Op: "chdir", Path: "", Err: 0x2}
        chdir : no such file or directory
    occurred

/retest

@mik-dass
Copy link
Contributor Author

Running odo with args [odo list --project qgxdkrgyyj]
[odo]  ✗  There are no components deployed.

/retest

@mik-dass
Copy link
Contributor Author

mik-dass commented Oct 1, 2019

 ✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name cmp-git. Please use `odo config view` to view settings used to create component. Error: unable to wait for build cmp-git-testing-1 to run: timed out waiting for the condition

/retest

@mik-dass
Copy link
Contributor Author

mik-dass commented Oct 1, 2019

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"
---
Container test exited with code 1, reason Error
---
Another process exited

/retest

@kadel
Copy link
Member

kadel commented Oct 3, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 3, 2019
@amitkrout
Copy link
Contributor

/retest

@amitkrout
Copy link
Contributor

amitkrout commented Oct 3, 2019

Will check it on my aws OpenShift 4.2 cluster atleast for 5 consecutive run.
Till then holding the pr
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 3, 2019
@amitkrout
Copy link
Contributor

Will check it on my aws OpenShift 4.2 cluster atleast for 5 consecutive run.
Till then holding the pr
/hold

I have executed 5 times on 4.2 OSD real cluster and none of the time i hit the issue of #1981
/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. labels Oct 3, 2019
@mik-dass
Copy link
Contributor Author

mik-dass commented Oct 3, 2019

 ✗  invalid configuration: [context was not found for specified context: zyasqblwkq/api-ci-op-h4d1xz7d-1b2f4-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]
[odo] Please login to your server: 

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit cff977b into redhat-developer:master Oct 3, 2019
@mik-dass mik-dass deleted the fix_git_double_push branch October 4, 2019 07:14
@rm3l rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flake] Failed to update config to git component deployed
7 participants