Run java test specs in parallel #1844

amitkrout · 2019-06-20T10:41:22Z

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes - part of #1473

How to test changes?

make test-java-e2e

amitkrout · 2019-06-20T15:50:31Z

Blocked due to #1846

amitkrout · 2019-06-28T09:10:59Z

/test integration

amitkrout · 2019-07-05T12:52:15Z

odo generic when .odoignore file exists 
  should create and push the contents of a named component excluding the contents in .odoignore file
  /go/src/github.com/openshift/odo/tests/integration/generic_test.go:104
 Creating a new project: iyirwywxlc
Running odo with args: [project create iyirwywxlc -w -v4] 
[odo] I0705 05:27:00.625993   12354 preference.go:116] The configFile is /tmp/artifacts/.odo/preference.yaml
[odo] I0705 05:27:00.626054   12354 occlient.go:455] Trying to connect to server api.ci-op-cxyqp9s0-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443
[odo] I0705 05:27:00.640618   12354 occlient.go:462] Server https://api.ci-op-cxyqp9s0-f09f4.origin-ci-int-aws.dev.rhcloud.com:6443 is up
[odo] I0705 05:27:00.723231   12354 occlient.go:385] isLoggedIn err:  <nil> 
[odo]  output: "developer"
[odo] I0705 05:27:00.723263   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: context
[odo] I0705 05:27:00.723271   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: context
[odo] I0705 05:27:00.723309   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: app
[odo] I0705 05:27:00.723317   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: project
[odo] I0705 05:27:00.744462   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: app
[odo] I0705 05:27:00.744491   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: output
[odo] I0705 05:27:00.744498   12354 context.go:355] Ignoring error as it usually means flag wasn't set: flag accessed but not defined: component
[odo]  •  Waiting for project to come up  ...
[odo]  ✓  Waiting for project to come up [425ms]
[odo]  ✓  Project 'iyirwywxlc' is ready for use
[odo]  ✓  New project created and now using project : iyirwywxlc
[odo] I0705 05:27:01.178295   12354 odo.go:70] Could not get the latest release information in time. Never mind, exiting gracefully :)
Created dir: /tmp/366751980
Running git with args: [clone https://github.com/openshift/nodejs-ex /tmp/366751980/nodejs-ex] 
[git] Cloning into '/tmp/366751980/nodejs-ex'...
Running odo with args: [create nodejs nodejs --project iyirwywxlc --context /tmp/366751980/nodejs-ex] 
[odo]  •  Validating component  ...
[odo]  ✓  Validating component [319ms]
[odo] Please use `odo push` command to create the component with source deployed
Running odo with args: [push --context /tmp/366751980/nodejs-ex] 
[odo] Validation
[odo]  •  Validating component  ...
[odo]  ✓  Validating component [403ms]
[odo]  •  Checking component  ...
[odo]  ✓  Checking component [18ms]
[odo] 
[odo] Configuration changes
[odo]  •  Creating component  ...
[odo]  ✓  Initializing component
[odo]  ✓  Creating component [183ms]
[odo]  •  Applying configuration  ...
[odo]  ✓  Applying configuration [10365ns]
[odo] 
[odo] Pushing to component nodejs of type local
[odo]  •  Waiting for component to start  ...
[odo]  ✓  Waiting for component to start [3m]
[odo]  •  Copying files to component  ...
[odo]  ✓  Copying files to component [34s]
[odo]  •  Building component  ...
[odo]  ✓  Building component [13s]
[odo]  ✓  Changes successfully pushed to component
Running oc with args: [get pods --namespace iyirwywxlc] 
[oc] NAME                  READY   STATUS    RESTARTS   AGE
[oc] nodejs-app-1-deploy   1/1     Running   0          3m38s
[oc] nodejs-app-1-fzt56    1/1     Running   0          3m28s
Running oc with args: [exec nodejs-app-1-deploy --namespace iyirwywxlc -- ls -lai /opt/app-root/src] 
[oc] error: unable to upgrade connection: container not found ("deployment")
Deleting project: iyirwywxlc
Running odo with args: [project delete iyirwywxlc -f] 
[odo] This project contains the following applications, which will be deleted
[odo] Application app
[odo] This application has following components that will be deleted
[odo] component named nodejs
[odo] No services / could not get services
[odo]  •  Deleting project iyirwywxlc  ...
[odo]  ✓  Deleting project iyirwywxlc [6s]
[odo] Deleted project : iyirwywxlc
 • Failure [229.293 seconds]
odo generic
/go/src/github.com/openshift/odo/tests/integration/generic_test.go:16
  when .odoignore file exists
  /go/src/github.com/openshift/odo/tests/integration/generic_test.go:92
    should create and push the contents of a named component excluding the contents in .odoignore file [It]
    /go/src/github.com/openshift/odo/tests/integration/generic_test.go:104
     No future change is possible.  Bailing out early after 0.338s.
      
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
     /go/src/github.com/openshift/odo/tests/helper/helper_run.go:29

Seems a new flake is introduced

amitkrout · 2019-07-05T12:55:06Z

/test integration

amitkrout · 2019-07-05T12:56:28Z

/refresh

amitkrout · 2019-07-06T07:17:12Z

[odo] ✗ Failed to create component with name wo-wait-javaee-git-test. Please use odo config view to view settings used to create component. Error: unable to wait for build wo-wait-javaee-git-test-app-1 to run: timed out waiting for the condition

/test integration

mohammedzee1000

As we add context flag to enable parallel testing we should ensure that we are doing atleast one test without context flag :)
Anycase looks good to me
/approve

mohammedzee1000 · 2019-07-08T06:16:38Z

tests/integration/java_test.go

 		})

-		It("Should be able to deploy a spring boot uberjar file using openjdk", func() {
+		// https://github.com/openshift/odo/issues/1846


I am assuming these tests do not pass as of now?

Yes, you are right.

It would be a good idea to record this as an issue so we remember to fix it

openshift-ci-robot · 2019-07-08T06:18:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mohammedzee1000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

amitkrout · 2019-07-08T06:39:54Z

As we add context flag to enable parallel testing we should ensure that we are doing atleast one test without context flag :)
Anycase looks good to me
/approve

Thanks for the review.
The combination of with and without context flag will be implemented in #1845

mik-dass

/lgtm

amitkrout · 2019-07-09T08:30:55Z

/test integration

openshift-bot · 2019-07-09T08:31:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-09T09:22:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the size/M label Jun 20, 2019

openshift-ci-robot requested review from girishramnani and mohammedzee1000 June 20, 2019 10:42

openshift-merge-robot force-pushed the master branch from 4eecf3e to 1098f67 Compare June 21, 2019 07:56

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 24, 2019

amitkrout force-pushed the javaParallelTestRun branch from 8e810e6 to 09f7ab2 Compare June 26, 2019 07:30

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Jun 26, 2019

amitkrout force-pushed the javaParallelTestRun branch from 65fa544 to 87ab207 Compare June 27, 2019 07:35

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 27, 2019

amitkrout force-pushed the javaParallelTestRun branch from 87ab207 to d3afa9e Compare June 28, 2019 10:22

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 1, 2019

amitkrout force-pushed the javaParallelTestRun branch from d3afa9e to 0ed2557 Compare July 4, 2019 15:54

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jul 4, 2019

amitkrout added 7 commits July 5, 2019 10:21

Run java test specs in parallel

39628e5

Updated binary path

05eefd3

Updated doc

3d3e362

Commented one spec

a7d0ae9

Commented one more spec

d03d443

Updated test file

ef07e77

Updated doc

eaf98ac

amitkrout force-pushed the javaParallelTestRun branch from 0ed2557 to eaf98ac Compare July 5, 2019 04:51

mohammedzee1000 approved these changes Jul 8, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 8, 2019

mik-dass approved these changes Jul 9, 2019

View reviewed changes

openshift-ci-robot assigned mik-dass Jul 9, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 9, 2019

openshift-merge-robot merged commit ff81dcb into redhat-developer:master Jul 9, 2019

rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run java test specs in parallel #1844

Run java test specs in parallel #1844

amitkrout commented Jun 20, 2019

amitkrout commented Jun 20, 2019

amitkrout commented Jun 28, 2019

amitkrout commented Jul 5, 2019 •

edited

Loading

amitkrout commented Jul 5, 2019

amitkrout commented Jul 5, 2019

amitkrout commented Jul 6, 2019

mohammedzee1000 left a comment

mohammedzee1000 Jul 8, 2019

amitkrout Jul 8, 2019

mohammedzee1000 Jul 8, 2019

openshift-ci-robot commented Jul 8, 2019

amitkrout commented Jul 8, 2019

mik-dass left a comment

amitkrout commented Jul 9, 2019

openshift-bot commented Jul 9, 2019

openshift-bot commented Jul 9, 2019

Run java test specs in parallel #1844

Run java test specs in parallel #1844

Conversation

amitkrout commented Jun 20, 2019

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

How to test changes?

amitkrout commented Jun 20, 2019

amitkrout commented Jun 28, 2019

amitkrout commented Jul 5, 2019 • edited Loading

amitkrout commented Jul 5, 2019

amitkrout commented Jul 5, 2019

amitkrout commented Jul 6, 2019

mohammedzee1000 left a comment

Choose a reason for hiding this comment

mohammedzee1000 Jul 8, 2019

Choose a reason for hiding this comment

amitkrout Jul 8, 2019

Choose a reason for hiding this comment

mohammedzee1000 Jul 8, 2019

Choose a reason for hiding this comment

openshift-ci-robot commented Jul 8, 2019

amitkrout commented Jul 8, 2019

mik-dass left a comment

Choose a reason for hiding this comment

amitkrout commented Jul 9, 2019

openshift-bot commented Jul 9, 2019

openshift-bot commented Jul 9, 2019

amitkrout commented Jul 5, 2019 •

edited

Loading