Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option to specify image pull policy for component container image #4494

Closed
awisniew90 opened this issue Mar 8, 2021 · 6 comments
Closed
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@awisniew90
Copy link
Contributor

/kind feature

Which functionality do you think we should add?

Odo should allow users to specify an image pull policy for a component's container image.

Why is this needed?

Using local images for components is particularly necessary when testing out stack image changes. Without being able to change the image pull policy, a local image cannot be used.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Mar 8, 2021
@awisniew90
Copy link
Contributor Author

Related to: devfile/api#89

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2021
@dharmit
Copy link
Member

dharmit commented Jul 7, 2021

/remove-lifecycle rotten
/area devfile
/lifecycle frozen

Since there's already an issue about this on devfile side, I'm setting lifecycle/frozen to this issue. It first needs to be addressed in devfile api and library, IMO.

@openshift-ci openshift-ci bot added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 7, 2021
@kadel
Copy link
Member

kadel commented Feb 8, 2023

recently released odo v3.6 added support for pod-overrides and container-overrides. This devfile features allows specifying imagePullPolicy.

Demo can be found in release notes https://odo.dev/blog/odo-v3.6.0/#extend-pod-and-container-specification-with-devfile-attributes-pod-overrides-and-container-overrides

adding the following lines to container component will change imagePullPolicy

    attributes:
      container-overrides:
        imagePullPolicy: IfNotPresent

/close

@openshift-ci openshift-ci bot closed this as completed Feb 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

@kadel: Closing this issue.

In response to this:

recently released odo v3.6 added support for pod-overrides and container-overrides. This devfile features allows specifying imagePullPolicy.

Demo can be found in release notes https://odo.dev/blog/odo-v3.6.0/#extend-pod-and-container-specification-with-devfile-attributes-pod-overrides-and-container-overrides

adding the following lines to container component will change imagePullPolicy

   attributes:
     container-overrides:
       imagePullPolicy: IfNotPresent

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Archived in project
Development

No branches or pull requests

6 participants