Skip to content

Commit

Permalink
ComponentTypeList should be List in machine output (#2230)
Browse files Browse the repository at this point in the history
For `odo catalog list components` machine-readable output for `Kind`
should simply be `List`
  • Loading branch information
cdrage authored and openshift-merge-robot committed Oct 7, 2019
1 parent 554f569 commit 78a1a88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/catalog/catalog.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func ListComponents(client *occlient.Client) (ComponentTypeList, error) {

return ComponentTypeList{
TypeMeta: metav1.TypeMeta{
Kind: "ComponentTypeList",
Kind: "List",
APIVersion: "odo.openshift.io/v1alpha1",
},
Items: catalogList,
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func componentTests(args ...string) {

// Since components catalog is constantly changing, we simply check to see if this command passes.. rather than checking the JSON each time.
output := helper.CmdShouldPass("odo", "catalog", "list", "components", "-o", "json")
Expect(output).To(ContainSubstring("ComponentTypeList"))
Expect(output).To(ContainSubstring("List"))
})

It("binary component should not fail when --context is not set", func() {
Expand Down

0 comments on commit 78a1a88

Please sign in to comment.