Skip to content

Commit

Permalink
Fix linting errors
Browse files Browse the repository at this point in the history
  • Loading branch information
EnriqueL8 committed Sep 11, 2020
1 parent ca0dd6c commit 51a5d36
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
1 change: 1 addition & 0 deletions pkg/odo/cli/component/component.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"github.com/openshift/odo/pkg/log"
"github.com/openshift/odo/pkg/occlient"
"github.com/openshift/odo/pkg/odo/util/completion"
"github.com/openshift/odo/pkg/odo/util/experimental"
"github.com/openshift/odo/pkg/url"
"github.com/pkg/errors"

Expand Down
10 changes: 2 additions & 8 deletions pkg/odo/cli/component/devfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,7 @@ func (po *PushOptions) devfilePushInner() (err error) {

//DevfileDeploy
func (do *DeployOptions) DevfileDeploy() (err error) {
componentName, err := getComponentName(do.componentContext)
if err != nil {
return errors.Wrap(err, "unable to get component name")
}
componentName := do.EnvSpecificInfo.GetName()

// Set the source path to either the context or current working directory (if context not set)
do.sourcePath, err = util.GetAbsPath(do.componentContext)
Expand Down Expand Up @@ -223,10 +220,7 @@ func (ddo *DeployDeleteOptions) DevfileDeployDelete() error {
return err
}

componentName, err := getComponentName(ddo.componentContext)
if err != nil {
return err
}
componentName := ddo.EnvSpecificInfo.GetName()
componentName = componentName + "-deploy"

kc := kubernetes.KubernetesContext{
Expand Down
2 changes: 1 addition & 1 deletion pkg/util/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ func TestDownloadInMemory(t *testing.T) {
for _, tt := range tests {

t.Run(tt.name, func(t *testing.T) {
_, err := DownloadFileInMemory(tt.url)
_, err := DownloadFileInMemory(HTTPRequestParams{URL: tt.url})

got := err == nil

Expand Down

0 comments on commit 51a5d36

Please sign in to comment.