Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: made compat with IC-2023.1 (#751) #760

Merged
merged 3 commits into from
Mar 30, 2023
Merged

refactor: made compat with IC-2023.1 (#751) #760

merged 3 commits into from
Mar 30, 2023

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Mar 29, 2023 •
edited
Loading

fixes #751

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@adietish adietish marked this pull request as ready for review March 29, 2023 14:55
@adietish adietish requested review from sbouchet and jeffmaury March 29, 2023 14:55
@adietish adietish changed the title made compat with IC-2023.1 (#751) fix: made compat with IC-2023.1 (#751) Mar 29, 2023
@adietish adietish changed the title fix: made compat with IC-2023.1 (#751) refactor: made compat with IC-2023.1 (#751) Mar 29, 2023
@adietish adietish force-pushed the issue-751 branch 3 times, most recently from 5b9d709 to fa1c93b Compare March 29, 2023 15:23
@adietish
refactor: made compat with IC-2023.1 (redhat-developer#751)
c2ad35d 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish self-assigned this Mar 29, 2023
@adietish adietish mentioned this pull request Mar 29, 2023
Merged
@sbouchet sbouchet mentioned this pull request Mar 29, 2023
Closed
@adietish adietish mentioned this pull request Mar 29, 2023
Closed
@adietish
moving intellij-common-ui-test-library to IT classpath (redhat-develo…
93ee973 
…per#751)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish
Copy link
Contributor Author

adietish commented Mar 29, 2023 •
edited
Loading

@jeffmaury, @sbouchet had to move com.redhat.devtools.intellij:intellij-common-ui-test-library:0.2.0 from testImplementation to integrationTestImplementation for it to compile (why?). Now it - at least - compiles.
But then ITs are failing. Any idea why?

@jeffmaury
Copy link
Member

ITs failed for a while you can ignore them

@adietish
Copy link
Contributor Author

adietish commented Mar 30, 2023 •
edited
Loading

ITs failed for a while you can ignore them

Oh, didn't know. Ok then.
@jeffmaury, @sbouchet: What do we do? +1 and merge?

@sbouchet
chore: made compatible to IC-2023.1
7ded725 
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sbouchet
Copy link
Contributor

ITs failed for a while you can ignore them

Oh, ok then. @jeffmaury, @sbouchet: What do we do? +1 and merge?

no, on my case it seems the contrary.
i have same errors as GH actions so reverting the testImplementation change

@adietish adietish mentioned this pull request Mar 30, 2023
Merged
sbouchet
sbouchet approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adietish adietish merged commit b0527bb into redhat-developer:main Mar 30, 2023
@adietish adietish deleted the issue-751 branch March 30, 2023 09:55
@openshift-ci openshift-ci bot added the lgtm label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury

Assignees

@adietish adietish

@sbouchet sbouchet

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix compatibility issues with IU-2023.1
3 participants
@adietish @jeffmaury @sbouchet