Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarkus.kubernetes.* properties not shown or validated #858

Closed
anton-seredkin-de opened this issue May 16, 2023 · 6 comments · Fixed by #1040
Closed

quarkus.kubernetes.* properties not shown or validated #858

anton-seredkin-de opened this issue May 16, 2023 · 6 comments · Fixed by #1040
Assignees
@angelozerr
Labels
bug Something isn't working completion quarkus Quarkus support validation
Milestone
1.24.0

Comments

@anton-seredkin-de
Copy link

However quarkus.kubernetes-client.* properties are shown in the autocomplete
@anton-seredkin-de anton-seredkin-de changed the title quarkus.kubernetes.* properties not show or validated quarkus.kubernetes.* properties not shown or validated May 16, 2023
@angelozerr
Copy link
Contributor

Im not sure if it is the reason but if I remember thiose properies comes from some deployment dependencies which define another deployment dependencies.

In JDT we support this usecase I dont know if it is working in IJ. I will test with vscode-quarkus

@fbricon fbricon added bug Something isn't working quarkus Quarkus support completion validation labels Jun 26, 2023
@angelozerr
Copy link
Contributor

@anton-seredkin-de could you share your project please.

@angelozerr
Copy link
Contributor

Ok I tested with vscode-quarkus and it works great. I think it is a problem with deployment JAR (which is not a simple topic), I will investigate the problem when I will have time.

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Jul 24, 2023
@angelozerr
fix: quarkus.kubernetes.* properties not shown or validated (redhat-d…
e0917bd 
…eveloper#858)

Fixes redhat-developer#858

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Jul 24, 2023
@angelozerr
fix: quarkus.kubernetes.* properties not shown or validated (redhat-d…
138152c 
…eveloper#858)

Fixes redhat-developer#858

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Jul 24, 2023
Merged
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Jul 24, 2023
@angelozerr
fix: quarkus.kubernetes.* properties not shown or validated (redhat-d…
3f2672c 
…eveloper#858)

Fixes redhat-developer#858

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

@anton-seredkin-de I'm fixing this issue, see demo at #1040 (comment)

angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue Jul 24, 2023
@angelozerr
fix: quarkus.kubernetes.* properties not shown or validated (redhat-d…
5dbb4dd 
…eveloper#858)

Fixes redhat-developer#858

Signed-off-by: azerr <azerr@redhat.com>
angelozerr added a commit that referenced this issue Jul 24, 2023
@angelozerr
fix: quarkus.kubernetes.* properties not shown or validated (#858)
c11fd4e 
Fixes #858

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this Jul 24, 2023
@angelozerr angelozerr added this to the 1.24.0 milestone Jul 24, 2023
@angelozerr angelozerr moved this to ✅ Done in IDE Cloudaptors Jul 24, 2023
@angelozerr
Copy link
Contributor

angelozerr commented Aug 3, 2023 •
edited
Loading

I reopen this issue which is about Quarkus Deployment which is implemented but provides 2 problems:

  • performance problem : the classpath can be updated too many time and takes some times
  • the goal of Quarkus deploiement is to provide properties in "hidden" JARS, but the clases of Quarkus deploiement should be not available in classpath, in otherwise Java completion should never seen the classes from Quarkus deploiement JAR

As we would like to create a release soon which will improve a lot performances we decide to disable it for the moment.

@angelozerr angelozerr reopened this Aug 3, 2023
@fbricon fbricon modified the milestones: 1.24.0, 1.25.0 Aug 3, 2023
@fbricon fbricon modified the milestones: 1.25.0, 1.24.0 Aug 16, 2023
@fbricon
Copy link
Contributor

fbricon commented Aug 16, 2023

Let's close this one now, as it works as expected, and we'll deal with the performance improvements in a later PR.

@fbricon fbricon closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion quarkus Quarkus support validation
Projects
IDE Cloudaptors
Archived in project
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

fix: quarkus.kubernetes.* properties not shown or validated (#858) angelozerr/intellij-quarkus
3 participants
@fbricon @angelozerr @anton-seredkin-de