Skip to content

Commit

Permalink
fix: error reported for empty PSI elements (#571)
Browse files Browse the repository at this point in the history
Fixes #568

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
  • Loading branch information
jeffmaury authored May 18, 2022
1 parent 325b377 commit 959b9b7
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiFile;
import com.intellij.psi.util.PsiUtilCore;
import com.redhat.devtools.intellij.quarkus.lsp4ij.LSPIJUtils;
import com.redhat.devtools.intellij.quarkus.lsp4ij.LanguageServerWrapper;
import com.redhat.devtools.intellij.quarkus.lsp4ij.LanguageServiceAccessor;
Expand Down Expand Up @@ -71,7 +72,12 @@ public ProblemDescriptor[] checkFile(@NotNull PsiFile file, @NotNull InspectionM
RangeHighlighter[] highlighters = LSPDiagnosticsToMarkers.getMarkers(editor, wrapper.serverDefinition.id);
if (highlighters != null) {
for(RangeHighlighter highlighter : highlighters) {
PsiElement element = new LSPPSiElement(editor.getProject(), file, highlighter.getStartOffset(), highlighter.getEndOffset(), editor.getDocument().getText(new TextRange(highlighter.getStartOffset(), highlighter.getEndOffset())));
PsiElement element;
if (highlighter.getEndOffset() - highlighter.getStartOffset() > 0) {
element = new LSPPSiElement(editor.getProject(), file, highlighter.getStartOffset(), highlighter.getEndOffset(), editor.getDocument().getText(new TextRange(highlighter.getStartOffset(), highlighter.getEndOffset())));
} else {
element = PsiUtilCore.getElementAtOffset(file, highlighter.getStartOffset());
}
ProblemHighlightType highlightType = getHighlighType(((Diagnostic)highlighter.getErrorStripeTooltip()).getSeverity());
problemDescriptors.add(manager.createProblemDescriptor(element, ((Diagnostic)highlighter.getErrorStripeTooltip()).getMessage(), true, highlightType, isOnTheFly));
}
Expand Down

1 comment on commit 959b9b7

@xunit-reporter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test status

Success Failed Errored Skipped
1 1 0 0

Please sign in to comment.