fix: java.lang.NullPointerException: Parameter specified as non-null is

null: method com.intellij.codeInsight.hints.presentation.PresentationFactory.smallText, parameter text #1036 Fixes (#1036) Signed-off-by: azerr <azerr@redhat.com>
redhat-developer · Jul 21, 2023 · 387b3de · 387b3de
1 parent 8291649
commit 387b3de
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/...ava/com/redhat/devtools/intellij/lsp4ij/operations/codelens/LSPCodelensInlayProvider.java b/...ava/com/redhat/devtools/intellij/lsp4ij/operations/codelens/LSPCodelensInlayProvider.java
@@ -116,8 +116,14 @@ private CompletableFuture<Void> collect(Document document, Project project, Code
                                         .thenAcceptAsync(codeLenses -> {
                                             // textDocument/codeLens may return null
                                             if (codeLenses != null) {
-                                                codeLenses.stream().filter(Objects::nonNull)
-                                                        .forEach(codeLens -> pairs.add(new Pair(codeLens, languageServer.getSecond())));
+                                                codeLenses.stream()
+                                                        .filter(Objects::nonNull)
+                                                        .forEach(codeLens -> {
+                                                            if (getCodeLensContent(codeLens) != null) {
+                                                                // The codelens content is filled, display it
+                                                                pairs.add(new Pair(codeLens, languageServer.getSecond()));
+                                                            }
+                                                        });
                                             }
                                         }))
                                 .toArray(CompletableFuture[]::new)));
@@ -138,7 +144,7 @@ private InlayPresentation toPresentation(
         elements.forEach(p -> {
             CodeLens codeLens = p.second.first;
             LanguageServer languageServer = p.second.second;
-            InlayPresentation text = factory.smallText(getCodeLensString(codeLens));
+            InlayPresentation text = factory.smallText(getCodeLensContent(codeLens));
             if (!hasCommand(codeLens)) {
                 // No command, create a simple text inlay hint
                 presentations.add(text);
@@ -171,7 +177,7 @@ private static boolean hasCommand(CodeLens codeLens) {
         return (command != null && command.getCommand() != null && !command.getCommand().isEmpty());
     }
 
-    private static String getCodeLensString(CodeLens codeLens) {
+    private static String getCodeLensContent(CodeLens codeLens) {
         Command command = codeLens.getCommand();
         if (command == null || command.getTitle().isEmpty()) {
             return null;