Add gitlab group config #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…true, which is probably the most sane default behavior now.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defaults to new behavior for reconfiguring Argo for private repositories - which is to use the
repository.credentialskey in the configmap instead of configuring individual entries in therepositorieskey. This allows us to avoid "making a mess" out of Argo's config by not having to modify it for every repository that we add.How should this be tested?
Deploy using the Helm chart
Is there a relevant Issue open for this?
resolves #15
Other Relevant info, PRs, etc.
People to notify
cc: @pabrahamsson @oybed @tylerauerbeck