Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in example option flag #163

Merged

Conversation

zhao-li
Copy link
Contributor

@zhao-li zhao-li commented Apr 1, 2020

What does this PR do?

The example usage -e provision: false did not work for me. Instead, changing it to -e provision=false worked.

How should this be tested?

This command didn't work ansible-playbook site.yml --ask-vault-pass -e provision: false
Whereas, this command worked: ansible-playbook site.yml --ask-vault-pass -e provision=false

Is there a relevant Issue open for this?

I didn't do much research.

Who would you like to review this?

cc: @redhat-cop/openshift-applier

Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM.

@oybed oybed added the bug Something isn't working label Apr 23, 2020
@oybed oybed merged commit 6c829b6 into redhat-cop:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants