-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add roles required for user reset #634
Conversation
23f1f8a
to
ad4ae2c
Compare
e816564
to
0d507e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some inline comments.
Also, let's find a better name for the grouping of roles to manage files - i.e.: file-management
or something like that instead of files
as the latter is generic and can be confused for some built-in location.
@oybed, I've incorporated those changes and will also update the corresponding paths in linked playbooks. |
Moved back to draft for additional testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a lot of good content. Main thread of comments is around git configuration and how we need to be careful to not step on someones existing configuration - especially avoid clobbering and/or removing it.
Some comment inline
- Undo permissions mistake - Dont remove global git creds - Remove jinja bool filters - Use bracket notation where required - Use more descriptive filename - Use clearer task name
ac14fa7
to
55f7b5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Undo permissions mistake - Dont remove global git creds - Remove jinja bool filters - Use bracket notation where required - Use more descriptive filename - Use clearer task name Co-authored-by: Øystein Bedin <oybed@users.noreply.github.com>
What does this PR do?
This PR adds the following;
Role for identity removal with success/fail/skip countersPlaybook that makes use of those roles for use in LodeStarHow should this be tested?
Roles can be tested individually, or demonstrated in conjunction with other changes in linked PR below.
Is there a relevant Issue open for this?
None
Other Relevant info, PRs, etc.
This is the first part of a 2-part PR, with the additional information available in lodestar-automation #66
Other related PR's include
People to notify
cc: @redhat-cop/infra-ansible