Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning Ansible Tower on OCP inventory with standalone Tower inventory #597

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

oybed
Copy link
Contributor

@oybed oybed commented Mar 24, 2021

What does this PR do?

Aligning the Ansible Tower install/configure roles to use the ansible_tower dict structure for inventory

How should this be tested?

Use the ansible_tower dict, with OpenShift information, to install Ansible Tower on OpenShift

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc.

N/A

People to notify

cc: @redhat-cop/infra-ansible @jfilipcz @paulbarfuss

@oybed
Copy link
Contributor Author

oybed commented Mar 24, 2021

@paulbarfuss @jfilipcz FYI - this is still a draft as I haven't had a chance to test it yet.

@jfilipcz
Copy link
Contributor

@paulbarfuss @jfilipcz FYI - this is still a draft as I haven't had a chance to test it yet.

@oybed , I've tested your PR, only thing that was failing was pg_host which is optional in Tower installer - otherwise it worked fine

@oybed oybed marked this pull request as ready for review March 30, 2021 23:00
@oybed oybed requested a review from paulbarfuss March 30, 2021 23:00
Copy link
Contributor

@paulbarfuss paulbarfuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulbarfuss paulbarfuss merged commit 4b9b23c into redhat-cop:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants