Add volume mounted SSH keys for Tower on Openshift #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbarfuss
changed the title
oybed
requested changes
Mar 16, 2021
roles/ansible/tower/config-ansible-tower-ocp-ssh/tasks/ocp-process-ssh-key.yml
Outdated
Show resolved
Hide resolved
paulbarfuss
force-pushed
the
add-tower-ocp-ssh-keys
branch
from
06651c0 to
47d00a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds one or more volume-mounted SSH key to Ansible Tower on Openshift. The basic pattern follows some of the recent work done on the installer using simple
occli commands:oc create secret generic ... oc set volume --type secret --add ...Also would like to add some single quotes to
oc logincommands to allow for use of special characters while crushing any attempts at shell expansion.How should this be tested?
Run the playbooks provided in the README against a running ansible-tower deployment and then verify the file permissions and content are correct:
This was also tested with various combinations of the secret or volume mount being either missing or present to ensure it properly add the file and skip the task if the key is already present.
Other Relevant info, PRs, etc.
Please provide link to other PRs that may be related (blocking, resolves, etc. etc.)
People to notify
cc: @redhat-cop/infra-ansible