Ansible Tower Deployment Role for Openshift #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resulting in partial Tower installation failure * Added automatic retrieval of OCP Token based on username/password * Cleanup of inventory template * Yamllint fixes * README update * defaults and test defaults update
oybed
requested changes
Mar 6, 2021
There was a problem hiding this comment.
Overall great job - this role seems to be working great, and I've tested it in many ways with a variety of inventory variables.
I submitted a PR for your PR to hep with some additional clean-up/nitpick changes. In addition, there's one inline comment.
However, the bigger item may be to keep files from the installer in this repo - not sure I agree with that approach. That fix is (hopefully) only needed for very short term, so I'd rather we maintain a .zip file locally some where with that change and just point to that .zip file at install time instead of adding it here. We can discuss offline on Monday.
| |openshift_token|Openshift token|yes(either that or password)|| | ||
| |admin_user|Tower admin username|yes|"admin"| | ||
| |admin_password|Tower admin user password|yes|"admin"| | ||
| |secret_key|Tower secret key|yes|"abcdefgh"| | ||
|
|
There was a problem hiding this comment.
Quite a few entries missing here - e.g.: pg_*,openshift_pg_*, and a few others. Please update per your defaults file and otherwise what the tasks and template calls for.
Clean-up and nitpick changes
… ansible_customization_file
enabling `no_log` for the `oc login` command
removing "dead" code
jfilipcz
added a commit
to jfilipcz/infra-ansible
that referenced
this pull request
Mar 16, 2021
…plied installer Lint fixes * Added workaround for Postgre Migration taking longer than expected, resulting in partial Tower installation failure * Added automatic retrieval of OCP Token based on username/password * Cleanup of inventory template * Yamllint fixes * README update * defaults and test defaults update Add a tower subscription from manifest.zip (redhat-cop#581) * first pass at adding a tower subscription from manifest.zip * Fix comma in template lookup * Allow configuration of retries/delay and update README Ansible tower updates (redhat-cop#582) * Updated READMEs and added a new 'wait' role * Updated README * Updated READMEs Clean-up and nitpick changes Clean-up Readme cleanup Yamllint fix Condition fix for Token retrieval Yamllint fix Added support for overwriting certain files within the Installer with ansible_customization_file Files cleanup Update openshift_retrieve_token.yml enabling `no_log` for the `oc login` command Update tower.yml removing "dead" code Ansible Tower Deployment Role for Openshift (redhat-cop#584) * Rewrite of Ansible Tower Openshift deployment role to use Red Hat supplied installer * Lint fixes * * Added workaround for Postgre Migration taking longer than expected, resulting in partial Tower installation failure * Added automatic retrieval of OCP Token based on username/password * Cleanup of inventory template * Yamllint fixes * README update * defaults and test defaults update * Clean-up and nitpick changes * Clean-up * Readme cleanup * Yamllint fix * Condition fix for Token retrieval * Yamllint fix * Added support for overwriting certain files within the Installer with ansible_customization_file * Files cleanup * Update openshift_retrieve_token.yml enabling `no_log` for the `oc login` command * Update tower.yml removing "dead" code Co-authored-by: Øystein Bedin <bedin@redhat.com> Co-authored-by: Øystein Bedin <oybed@users.noreply.github.com> Initial molecule test for config-timezone (redhat-cop#586) * Initial molecule test for timezone * Remove fedora test for now * Remove debug statement Updated docker image README (redhat-cop#583) * Updated docker image README * Fixing lint errors Co-authored-by: Tyler Auerbeck <tauerbec@redhat.com> Add conditional for credentials managed by tower (redhat-cop#588) * add conditional for credentials managed by tower * Add note to README about credential cleanup Adding option to serve ansible tower .zip file locally (redhat-cop#585) * Adding option to serve ansible tower .zip file locally * Adding option to serve ansible tower .zip file locally * Adding option to serve ansible tower .zip file locally * Update README.md Fixing "broken" URL for example value Adding support for automatic deployment of PostgreSQL PVC Improved readiness check for PVC Adding support for automatic deployment of PostgreSQL PVC Improved readiness check for PVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is changing the way we deploy Tower to Openshift, in favor of using Red Hat provided Tower installer.
How should this be tested?
Please see test directory for instructions and test inventory
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc.
N/A
People to notify
cc: @redhat-cop/infra-ansible