Adding role to configure hostname #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roles/config-hostname/README.md
Outdated
|
|
||
| ``` | ||
| --- | ||
| ansible_become: True |
There was a problem hiding this comment.
LGTM. Only comment I have is around ansible_become. I know in other roles we've gone down the path of just using become on the necessary tasks. Did we want to do this here as well?
There was a problem hiding this comment.
Since all of these tasks requires elevated privileges, I think I could go either way. I can add a block to enforce it though - it's fine.
tylerauerbeck
approved these changes
Aug 22, 2018
sabre1041
approved these changes
Aug 22, 2018
tylerauerbeck
pushed a commit
to tylerauerbeck/infra-ansible
that referenced
this pull request
Aug 31, 2018
* Adding role to configure hostname * Updated README * Updated to have a default value for 'hostname' * Updating based on Tyler's feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In preparation to "decouple" casl-ansible from the openshift-ansible-contrib repo, this role introduces the option to configure the hostname of a vm/instance/host.
This PR re-introduces the functionality of the hostnames role, with some clean-up and improvements.
See role's README for further details.
How should this be tested?
Update the inventory in the role's tests directory to mach your target host, then run the
test.ymlplaybookIs there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc.
N/A
People to notify
cc: @redhat-cop/infra-ansible