Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use --random_generator=tausworthe64 #200

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

jackhodgkiss
Copy link
Contributor

@jackhodgkiss jackhodgkiss commented Nov 15, 2024

If disks are large enough then FIO will write to stdout a warning that the default random generator is not sufficient. As this is written to stdout the subsequent attempt to parse the JSON will fail as it contains the warning before the JSON object.

To fix we can set the random generator to tausworthe64 which will suppress the warning allow for the JSON to be parsed without error.

This issue has been noticed on disks around 64TB in size however could occur on smaller disks.

Fixes #201

@elfosardo
Copy link
Collaborator

thanks, this looks good
please fix the line length as indicated by the pep8 test

If disks are large enough then FIO will write to stdout a warning that
the default random generator is not sufficient. As this is written to
stdout the subsequent attempt to parse the JSON will fail as it contains
the warning before the JSON object.

To fix we can set the random generator to `tausworthe64` which will
suppress the warning allow for the JSON to be parsed without error.

This issue has been noticed on disks around 64TB in size however could
occur on smaller disks.
@elfosardo elfosardo merged commit 93c555b into redhat-cip:master Nov 19, 2024
15 checks passed
@priteau priteau deleted the set-random-generator branch January 10, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON parsing fails due to FIO random generator warning
2 participants