Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make startup of the handler fail-safe #27

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Make startup of the handler fail-safe #27

merged 1 commit into from
Dec 2, 2020

Conversation

kusha
Copy link
Contributor

@kusha kusha commented Dec 2, 2020

  • set enabled flag on startup
  • in case of any exception disable the logger
  • teardown atexit (which attempts to flush)
  • skip flush, which is triggered on logger shutdown

@kusha
Make startup of the handler fail-safe
03dcbae 
- set enabled flag on startup
- in case of any exception disable the logger
- teardown atexit (which attempts to flush)
- skip flush, which is triggered on logger shutdown
@jvulgan
Copy link

jvulgan commented Dec 2, 2020

LGTM

@lkrajice
Copy link

lkrajice commented Dec 2, 2020

@kusha LGTM

@kusha kusha merged commit 937410c into redhat-aqe:master Dec 2, 2020
@kusha kusha deleted the failsafe branch December 2, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kusha @jvulgan @lkrajice