Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.4] Improve UX when using a container to deploy RHTAP #403

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[release-1.4] Improve UX when using a container to deploy RHTAP #403

merged 2 commits into from
Jan 23, 2025

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #402

/assign Roming22

@Roming22
feat: Enable githubapp integration from a container
0d1b99a 
The service listening on the loopback device was preventing the host to
access the service running in the container.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22
fix: Add KUBECONFIG env var to the container
8ca2ff3 
Having a default location will help simplify the docs.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 23, 2025
Merged
@openshift-ci openshift-ci bot requested review from jkopriva and xinredhat January 23, 2025 16:45
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Roming22
Roming22 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Roming22 Roming22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Roming22
Copy link
Member

/ok-to-test

@openshift-merge-bot openshift-merge-bot bot merged commit a1e55ab into redhat-appstudio:release-1.4 Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roming22 Roming22 Roming22 approved these changes

@jkopriva jkopriva Awaiting requested review from jkopriva

@xinredhat xinredhat Awaiting requested review from xinredhat

Assignees

@Roming22 Roming22

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@openshift-cherrypick-robot @Roming22