-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHTAPINST-186: GitHub Release Action vs. Container Image #341
RHTAPINST-186: GitHub Release Action vs. Container Image #341
Conversation
/hold |
b63574c
to
30efb3f
Compare
30efb3f
to
bad68cc
Compare
|
/hold cancel |
@otaviof: This pull request references RHTAPINST-186 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is giid. You cannot grab a secret in an action, it needs to be the workflow.
Change looks good to me (I made the same ones)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jduimovich, otaviof The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/lgtm |
bf1c201
into
redhat-appstudio:main
/cherry-pick release-1.3 |
@xinredhat: new pull request created: #342 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixing
buildah
GitHub Action error, and skipping container build in GHA given we need credentials to fetch Red Hat images.