Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHTAPINST-186: GitHub Release Action vs. Container Image #341

Merged

Conversation

otaviof
Copy link
Collaborator

@otaviof otaviof commented Dec 5, 2024

Fixing buildah GitHub Action error, and skipping container build in GHA given we need credentials to fetch Red Hat images.

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 5, 2024

/hold

@otaviof otaviof force-pushed the fix-release-action branch 7 times, most recently from b63574c to 30efb3f Compare December 5, 2024 19:26
@otaviof otaviof force-pushed the fix-release-action branch from 30efb3f to bad68cc Compare December 5, 2024 19:28
Copy link

sonarqubecloud bot commented Dec 5, 2024

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 5, 2024

/hold cancel

@otaviof otaviof changed the title fix: Release action RHTAPINST-186: GitHub Release Action vs. Container Image Dec 5, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 5, 2024

@otaviof: This pull request references RHTAPINST-186 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Fixing buildah GitHub Action error, and skipping container build in GHA given we need credentials to fetch Red Hat images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 5, 2024

/retest

1 similar comment
@otaviof
Copy link
Collaborator Author

otaviof commented Dec 5, 2024

/retest

Copy link

@jduimovich jduimovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is giid. You cannot grab a secret in an action, it needs to be the workflow.
Change looks good to me (I made the same ones)

@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jduimovich, otaviof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@otaviof
Copy link
Collaborator Author

otaviof commented Dec 5, 2024

/retest

@xinredhat
Copy link
Member

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit bf1c201 into redhat-appstudio:main Dec 6, 2024
11 checks passed
@xinredhat
Copy link
Member

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Collaborator

@xinredhat: new pull request created: #342

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@otaviof otaviof deleted the fix-release-action branch December 6, 2024 08:30
@otaviof otaviof restored the fix-release-action branch December 6, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants