install.sh: set vars from files only if needed #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my RHTAP development workflow, I want to disable some features and leave the related environment variables unset. Currently, I can't do that because the install script will try to read the values for those variables from files in /usr/local/rhtap-cli-install. Change the script to read from /usr/local/rhtap-cli-install only if the variable is unset AND the corresponding feature is enabled. Signed-off-by: Adam Cmiel <acmiel@redhat.com>
chmeliik
force-pushed
the
more-flexible-installscript
branch
from
b0b5249 to
07b0a7f
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
Looks like all the tests finally passed 🎉 |
|
/lgtm |
|
|
/retest |
|
/lgtm |
Roming22
approved these changes
Dec 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmeliik, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9d9e568
into
redhat-appstudio:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my RHTAP development workflow, I want to disable some features and leave the related environment variables unset. Currently, I can't do that because the install script will try to read the values for those variables from files in /usr/local/rhtap-cli-install.
Change the script to read from /usr/local/rhtap-cli-install only if the variable is unset AND the corresponding feature is enabled.