-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use ose-tools to get kubectl and enable hermetic builds #228
base: main
Are you sure you want to change the base?
Conversation
7153369
to
41ab01f
Compare
/retest |
1 similar comment
/retest |
31dd12f
to
5ddcd2a
Compare
Dockerfile
Outdated
COPY --from=builder /workdir/rhtap-cli/installer ./ | ||
|
||
COPY --from=builder /workdir/rhtap-cli/bin/rhtap-cli /usr/local/bin/rhtap-cli | ||
COPY --from=builder /usr/bin/tar /usr/bin/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tar' & 'gzip' not needed if we copy 'kubectl' from an image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold |
Quality Gate passedIssues Measures |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flacatus, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.