Improve crosshair health display #980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qreeves
requested changes
Dec 29, 2019
The new implementation has numerous upsides compared to the previous implementation: - It indicates the player's health more accurately using a color gradient well-known among FPS players. Health above 100 is indicated by tinting the crosshair green. - It's always visible, even in screenshots. Due to lack of animation, it also avoids hiding the health status on every loop of the animation (since the crosshair became white). The variable was renamed from `crosshairflash` to `crosshairhealth` to reflect the change.
Calinou
force-pushed
the
improve-crosshair-health-display
branch
from
b5a21ed to
27a2df8
Compare
qreeves
approved these changes
Dec 29, 2019
q009
approved these changes
Jun 5, 2022
qreeves
requested changes
Jun 11, 2022
There was a problem hiding this comment.
I've looked at this more closely, and my issue with it is that it replaces the flash with the colour completely. I, personally, don't like the crosshair changing colour, which is why this was implemented as a flash instead that only alerts to low health.
Also the variable being used was only renamed in the usage.cfg and not in the source code. I suggest it be a bitwise variable: &1 = flash, &2 = colour. This way you can combine the two effects if you want as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation has numerous upsides compared to the previous implementation:
is indicated by tinting the crosshair green.
The variable was renamed from
crosshairflashtocrosshairhealthto reflect the change.