-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error mapping list feature to oidc login method #1387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use shared DTO lib.
…dded type conversion convenience method.
# Conflicts: # angular/package-lock.json # angular/package.json # core/package-lock.json # package-lock.json # package.json # tsconfig.json
…, declaration types added to TS compliation
…ell as supporting custom form components.
- conflict resolution - updates to Typescript imports caused by ongoing shift from CommonJS to ES6 - core-types updated to be in line with upcoming form changes - introduced but disabled the new form app, as form field components are rebuilt
# Conflicts: # package-lock.json # package.json
…matic chars and symbols
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #1387 +/- ##
========================================
Coverage 69.94% 69.94%
========================================
Files 110 110
Lines 1863 1863
Branches 216 216
========================================
Hits 1303 1303
Misses 560 560
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to allow oidc login config to handle error mappings. The configuration is expecting a list of error mapping objects that each one can be be configured to suit different needs. In example to match based on a regex pattern or to match based on a simple match string. And example configuration to capture different errors may be as below: