Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #314

Merged
merged 6 commits into from
Feb 3, 2025
Merged

Update examples #314

merged 6 commits into from
Feb 3, 2025

Conversation

StuartHarris
Copy link
Member

@StuartHarris StuartHarris commented Jan 31, 2025 •
edited
Loading

  • update cat_facts example to use new crux_time
  • update notes example to use Command (including PubSub capability) and crux_time (instead of custom Timer capability). Also to remove use of AppTester in tests.
  • add Command::expect_one_effect to do the same job as Update::expect_one_effect

@StuartHarris StuartHarris force-pushed the examples-time branch 2 times, most recently from c549395 to ea6c327 Compare February 3, 2025 13:47
@StuartHarris StuartHarris marked this pull request as ready for review February 3, 2025 13:58
@StuartHarris StuartHarris requested a review from charypar February 3, 2025 13:59
charypar
charypar approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@charypar charypar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Couple questions, but nothing major - most of them are just around setting the right example in the... example... code 😅

examples/cat_facts/shared/src/app.rs Outdated Show resolved Hide resolved
examples/cat_facts/shared/src/app.rs Outdated Show resolved Hide resolved
examples/notes/shared/src/app.rs Show resolved Hide resolved
examples/notes/shared/src/app.rs Show resolved Hide resolved
@StuartHarris StuartHarris requested a review from charypar February 3, 2025 15:30
charypar
charypar approved these changes Feb 3, 2025
View reviewed changes
examples/cat_facts/shared/src/app.rs Outdated Show resolved Hide resolved
@StuartHarris StuartHarris merged commit e63b2de into master Feb 3, 2025
9 checks passed
@StuartHarris StuartHarris deleted the examples-time branch February 3, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charypar charypar charypar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StuartHarris @charypar