feat(Form): add novalidate flag to form (patternfly#1253)

redallen · Jan 28, 2019 · 5e54437 · 5e54437
1 parent 62059db
commit 5e54437
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/packages/patternfly-4/react-core/src/components/Form/Form.js b/packages/patternfly-4/react-core/src/components/Form/Form.js
@@ -22,7 +22,7 @@ const defaultProps = {
 };
 
 const Form = ({ className, children, isHorizontal, ...props }) => (
-  <form {...props} className={css(styles.form, isHorizontal && styles.modifiers.horizontal, className)}>
+  <form noValidate {...props} className={css(styles.form, isHorizontal && styles.modifiers.horizontal, className)}>
     <FormContext.Provider value={{ isHorizontal }}>{children}</FormContext.Provider>
   </form>
 );

diff --git a/packages/patternfly-4/react-core/src/components/Form/__snapshots__/ActionGroup.test.js.snap b/packages/patternfly-4/react-core/src/components/Form/__snapshots__/ActionGroup.test.js.snap
@@ -38,6 +38,7 @@ exports[`ActionGroup component should render horizontal form ActionGroup variant
 >
   <form
     className="pf-c-form pf-m-horizontal"
+    noValidate={true}
   >
     <ActionGroup
       className=""

diff --git a/packages/patternfly-4/react-core/src/components/Form/__snapshots__/Form.test.js.snap b/packages/patternfly-4/react-core/src/components/Form/__snapshots__/Form.test.js.snap
@@ -8,6 +8,7 @@ exports[`Form component should render default form variant 1`] = `
 
 <form
   className="pf-c-form"
+  noValidate={true}
 >
   <[object Object]
     value={
@@ -27,6 +28,7 @@ exports[`Form component should render horizontal form variant 1`] = `
 
 <form
   className="pf-c-form pf-m-horizontal"
+  noValidate={true}
 >
   <[object Object]
     value={

diff --git a/packages/patternfly-4/react-core/src/components/Form/__snapshots__/FormGroup.test.js.snap b/packages/patternfly-4/react-core/src/components/Form/__snapshots__/FormGroup.test.js.snap
@@ -491,6 +491,7 @@ exports[`FormGroup component should render horizontal form group variant 1`] = `
 >
   <form
     className="pf-c-form pf-m-horizontal"
+    noValidate={true}
   >
     <FormGroup
       className=""