fix(Slider): Update state when properties are updated. (patternfly#1223)

redallen · Jan 25, 2019 · 033a38b · 033a38b
1 parent abab0d4
commit 033a38b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/packages/patternfly-3/patternfly-react/src/components/Slider/Slider.js b/packages/patternfly-3/patternfly-react/src/components/Slider/Slider.js
@@ -17,12 +17,19 @@ class Slider extends React.Component {
     };
   }
 
+  componentDidUpdate(prevProps) {
+    if (prevProps.value !== this.props.value) {
+      this.onSlide(this.props.value);
+    }
+  }
+
   onSlide = value => {
     this.setState({ value }, () => this.props.onSlide(value));
   };
 
   onInputChange = event => {
-    this.setState({ value: parseInt(event.target.value || 0, 10) });
+    const newValue = parseInt(event.target.value || 0, 10);
+    this.setState({ value: newValue }, () => this.props.onSlide(newValue));
   };
 
   onFormatChange = format => {