fix(Slider): Update state when properties are updated. #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasponce
changed the title
Invoke onSlide when slider-input changes
lucasponce
force-pushed
the
fix-slider-bugs
branch
from
978ce67 to
d7f3aa9
Compare
|
PatternFly-React preview: https://1223-pr-patternfly-react-patternfly.surge.sh |
Pull Request Test Coverage Report for Build 4080
💛 - Coveralls |
jeff-phillips-18
requested changes
Jan 24, 2019
| @@ -17,12 +17,19 @@ class Slider extends React.Component { | |||
| }; | |||
| } | |||
|
|
|||
| componentDidUpdate(prevProps) { | |||
| if (prevProps.value !== this.props.value) { | |||
| this.onSlide(this.props.value); | |||
There was a problem hiding this comment.
state be updated here as well
There was a problem hiding this comment.
State needs to be updated when properties change.
There was a problem hiding this comment.
I didn't change here the state as it triggers a warning and the CI was blocked and also the onSlide needs to be invoked and it updates the state as side effect.
So I think on this way, it saves one render.
There was a problem hiding this comment.
Ah, I see... the onSlide function updates the state 👍
(it's a bit confusing to have both a this.onSlide and a this.props.onSlide)
jeff-phillips-18
approved these changes
Jan 24, 2019
dtaylor113
approved these changes
Jan 24, 2019
priley86
approved these changes
Jan 24, 2019
aljesusg
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke onSlide when slider-input changes
Fixes #1221