Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: add target to checkout timestamp only changes in bundle #502

Merged
merged 2 commits into from
Nov 13, 2024
Merged

makefile: add target to checkout timestamp only changes in bundle #502

merged 2 commits into from
Nov 13, 2024

Conversation

iamniting
Copy link
Member

Signed-off-by: Nitin Goyal nigoyal@redhat.com

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024
@iamniting
makefile: add target to checkout timestamp only changes in bundle
a07bd37 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
action: remove timestamp check from the github action
4151611 
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting force-pushed the makefile branch 2 times, most recently from 2a0eda8 to 4151611 Compare November 13, 2024 15:09
malayparida2000
malayparida2000 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iamniting
Copy link
Member Author

/override ci/prow/odf-operator-e2e-aws

e2e is not effected by this change.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/odf-operator-e2e-aws

In response to this:

/override ci/prow/odf-operator-e2e-aws

e2e is not effected by this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 1ad1323 into red-hat-storage:main Nov 13, 2024
17 checks passed
@iamniting iamniting deleted the makefile branch November 13, 2024 16:02
iamniting added a commit to iamniting/odf-operator that referenced this pull request Nov 14, 2024
@iamniting
action: remove comment
b1b01c3 
The code was removed as part of the red-hat-storage#502 But comment was left.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting iamniting mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malayparida2000 malayparida2000 malayparida2000 approved these changes

Assignees

@malayparida2000 malayparida2000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamniting @malayparida2000