Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from main for odf-must-gather #214

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from main branch

black-dragon74 and others added 2 commits November 21, 2024 20:06
This patch adds a script that parses and strips of extraneous
info from the `rook-ceph-external-cluster-details` secret.

This secret is namespaced to the ODF install namespace.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
DFBUGS-727: gather: Add a script to collect external cluster details
@df-build-team df-build-team requested a review from a team November 23, 2024 02:25
@Nikhil-Ladha
Copy link
Member

@yati1998 please approve and merge this PR

@Nikhil-Ladha Nikhil-Ladha added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Nov 26, 2024
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8245193 into release-4.18 Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants