Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automating MOD hotfix 404 again - testing complete and abort multipart upload race #651

Merged

Conversation

@hmaheswa hmaheswa force-pushed the MOD_hotfix_404_again branch from beb6d1f to 8160d3d Compare December 31, 2024 16:38
@hmaheswa hmaheswa added RGW RGW pr-verified close-loop-automation close-loop-automation customer BZ automated as part of close-loop hotfix automation done during the testing of any hotfix labels Dec 31, 2024
@hmaheswa hmaheswa force-pushed the MOD_hotfix_404_again branch from 8160d3d to 2755980 Compare December 31, 2024 18:04
@hmaheswa hmaheswa requested a review from a team December 31, 2024 18:04
Copy link
Contributor

@ckulal ckulal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the minor comment added remaining changes looks good.

@hmaheswa hmaheswa force-pushed the MOD_hotfix_404_again branch from 2755980 to 94bfdc5 Compare January 1, 2025 07:39
…t upload race

Signed-off-by: Hemanth Sai Maheswarla <hemanthsaimaheswarla@Hemanths-MacBook-Pro.local>
@hmaheswa hmaheswa force-pushed the MOD_hotfix_404_again branch from 4705770 to 065b90a Compare January 1, 2025 13:02
Copy link
Contributor

@anrao19 anrao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jan 2, 2025
@TejasC88
Copy link
Contributor

TejasC88 commented Jan 3, 2025

LGTM

@TejasC88 TejasC88 added the approved Approving PR. label Jan 7, 2025
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: anrao19, hmaheswa, TejasC88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ae483d3 into red-hat-storage:master Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approving PR. close-loop-automation close-loop-automation customer BZ automated as part of close-loop hotfix automation done during the testing of any hotfix lgtm Looks good to me pr-verified RGW RGW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants