Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the CRLF fault injection using CORS #646

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

TejasC88
Copy link
Contributor

@TejasC88 TejasC88 commented Nov 27, 2024

BZ Details : https://bugzilla.redhat.com/show_bug.cgi?id=2040886
Polarion ID : CEPH-83574745

  1. create bucket
  2. set cors configuration to the created bucket with 'Expose-headers' set to CRLF fault
  3. Put object with Origin header and observe the debug response the '\r' from the expose header should be escaped from the output.

Pass log : http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/CRLF_injection.txt

Related pass log due to changed in curl/resource_op.py :
http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/cors_using_curl.txt
http://magna002.ceph.redhat.com/cephci-jenkins/tchandra/test_rgw_using_curl.txt

@TejasC88 TejasC88 force-pushed the clrf branch 2 times, most recently from e5d2b49 to 8525bc1 Compare November 27, 2024 07:55
@TejasC88 TejasC88 requested review from a team and anrao19 November 27, 2024 07:56
@TejasC88 TejasC88 requested review from hmaheswa and removed request for a team December 4, 2024 10:41
anrao19
anrao19 previously approved these changes Dec 9, 2024
Copy link
Contributor

@anrao19 anrao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 9, 2024
config:
user_count: 1
bucket_count: 1
objects_count: 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TejasC88 pls increase objects count to say 25

Signed-off-by: Tejas Chandramouli <tchandra@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 16, 2024
Copy link
Contributor

@anrao19 anrao19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19, hmaheswa, mkasturi18, TejasC88

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot merged commit 3f73b3f into red-hat-storage:master Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me RGW RGW Tier-2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants