Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport]fix: do not apply resource till applyparams() calls #347

Open
wants to merge 1 commit into
base: rhoai-2.10
Choose a base branch
from

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Sep 11, 2024

Description

from original commit 005b9d2

https://issues.redhat.com/browse/RHOAIENG-12732

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

 from original commit red-hat-data-services@005b9d2

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Author

zdtsw commented Sep 12, 2024

test the unit-test locally, and can reproduce the same error,
which even happend in previous commit, which we did not have unit-test in GHA.

do not feel we must feel this for 2.10.0 if this is not related to the bug fix and introduce changes even testcase should be avoid?
@VaishnaviHire wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant